Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: pass output instead of the path. #1377

Closed
wants to merge 1 commit into from
Closed

Bugfix: pass output instead of the path. #1377

wants to merge 1 commit into from

Conversation

mms-gianni
Copy link
Contributor

Fixes the following Error :

2015-02-18 13:35:49,980 | ERROR | dd.collector | checks.varnish(__init__.py:556) | Check 'varnish' instance #0 failed
Traceback (most recent call last):
  File "/opt/datadog-agent/agent/checks/__init__.py", line 547, in run
    self.check(copy.deepcopy(instance))
  File "/opt/datadog-agent/agent/checks.d/varnish.py", line 95, in check
    self._parse_varnishstat(varnishstat_path, use_xml, tags)
  File "/opt/datadog-agent/agent/checks.d/varnish.py", line 182, in _parse_varnishstat
    p.Parse(output, True)

@mms-gianni mms-gianni mentioned this pull request Feb 18, 2015
Merged
@LeoCavaille
Copy link
Member

@mms-gianni thanks for fixing this regression so quickly and sorry for the trouble.
We're preparing a bugfix release with your fix.

@remh remh added this to the 5.2.1 milestone Feb 18, 2015
@LeoCavaille LeoCavaille mentioned this pull request Feb 19, 2015
Merged
@LeoCavaille
Copy link
Member

Merged on #1384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LeoCavaille LeoCavaille

Labels
1 - Ready bugfix
Projects
None yet
Milestone
5.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mms-gianni @LeoCavaille @remh